Dear Stefan Roese, In message <200909111012.07310...@denx.de> you wrote: > > > This patch breaks building for a number of boards / configurations, > > especially: > > > > xilinx-ppc405-generic_flash > > xilinx-ppc405-generic > > xilinx-ppc440-generic_flash > > xilinx-ppc440-generic > > VoVPN-GW_66MHz > > VoVPN-GW_100MHz > > EB+MCF-EV123 > > EB+MCF-EV123_internal > > microblaze-generic > > favr-32-ezkit > > Yes, I just stumbled over the build failure here as well. It seems to be a > problem with the "-" in the board target name. Not sure how this could be > solved though.
Yes. The modification was based on the assumption that Make target names _and_ board config file names could be used as valid C identifiers, which is obviously not the case. Of course we could rename the respective Make targets and directories, but this is (1) some effort and (2) requires negotiation with the respective board maintainers, as documentation, build scripts and other things may be effected by such a change. Alternatively, we could filter out such problematic characters, but then again we have to check which side effects this may cause. All together: this patch needs a lot more thinking and more careful testing. I tend to revert it. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de People are always a lot more complicated than you think. It's very important to remember that. - Terry Pratchett, _Truckers_ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
