On Tue, May 17, 2016 at 4:58 PM, Simon Glass <s...@chromium.org> wrote: > +Joe > > > On 16 May 2016 at 23:11, Wenyou Yang <wenyou.y...@atmel.com> wrote: >> Use the right phy_connect() prototype for CONFIGF_DM_ETH. >> Support to get the phy interface from dt and set GMAC_UR. >> >> Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> >> --- >> This patch is based on the patch set, >> [PATCH 00/18] at91: Convert Ethernet and LCD to driver model >> http://lists.denx.de/pipermail/u-boot/2016-May/253559.html >> >> Hi Simon, >> >> With this patch, the ethernet works on SAMA5D2 Xplained board. >> But it includes a lot of #ifdef, I think it is not pretty. >> >> What is your opinions? > > I believe there is a new PHY interface that might help. I added Joe in > case he can help. > > We should move PHYs to driver model but apparently that is tricky to > do at present.
This is pretty messy, indeed. The issue is that there is no common way to define phy connections. Each MAC driver has its own way. I think if the implementation is this messy, maybe we are better off waiting. -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
