On 05/23/2016 02:18 AM, Shengzhou Liu wrote: >> -----Original Message----- >> From: York Sun [mailto:york....@nxp.com] >> Sent: Friday, May 20, 2016 11:29 PM >> To: Shengzhou Liu <shengzhou....@nxp.com>; u-boot@lists.denx.de >> Subject: Re: [PATCH] driver/ddr/fsl: Force enabling parity for A-009803 >>> >> >> Shengzhou, >> >> It looks backward. You should detect if the condition is right before >> applying the workaround, not by forcing the condition. >> >> York > > If ERRATUM_A009803 is defined, ap_en should always be enabled whatever user > configures parity=on in hwconfig. > As ERRATUM_A009803 is enabled only in arch-fsl-layerscape/config.h for LS2 > SoC, I don't think we need to check anything other. > What condition do you mean? >
Shengzhou, My point is you should force ap=1. Do you mean if ERRATUM_A009803 is enabled, users are forced to use address parity? That doesn't sound right. We have been running UDIMM without address parity for a long time. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
