Dear Graeme Russ, In message <1250996401-13642-8-git-send-email-graeme.r...@gmail.com> you wrote: > Cast first parameter to sata_cpy() > > In /drivers/block/ata_piix.h, ata_id_has_lba48(), ata_id_has_lba(), > ata_id_has_dma(), ata_id_u32(), ata_id_u64() are all defined in > include/libata.h which is included in ata.h which is included by all files > which include ata_piix.h (only ata_piix.c) so these definitions are > supurflous to (and conlict with) this in libata.h. Interestingly, my > compiler complains about ata_id_u64 already being defined, but not > ata_id_u32 > > ata_dump_id() is defined in include/libata.h and should not be static > (maybe should even use ata_dump_id() in libata.c > > Signed-off-by: Graeme Russ <graeme.r...@gmail.com> > --- > drivers/block/ata_piix.c | 10 +++++----- > drivers/block/ata_piix.h | 15 +-------------- > 2 files changed, 6 insertions(+), 19 deletions(-)
Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de My play was a complete success. The audience was a failure. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
