On Apr 5, 2016 3:08 PM, "Marek Vasut" <ma...@denx.de> wrote: > > On 04/04/2016 10:30 PM, Steve Rae wrote: > > Hi Marek, > > > > On Mon, Apr 4, 2016 at 1:02 PM, Marek Vasut <ma...@denx.de> wrote: > >> > >> On 04/04/2016 09:59 PM, Steve Rae wrote: > >>> Turn on the USB OTG clocks. > >>> > >>> Signed-off-by: Steve Rae <s...@broadcom.com> > >>> --- > >>> > >>> drivers/usb/gadget/bcm_udc_otg_phy.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/usb/gadget/bcm_udc_otg_phy.c b/drivers/usb/gadget/bcm_udc_otg_phy.c > >>> index 10b2e13..877f162 100644 > >>> --- a/drivers/usb/gadget/bcm_udc_otg_phy.c > >>> +++ b/drivers/usb/gadget/bcm_udc_otg_phy.c > >>> @@ -8,12 +8,16 @@ > >>> #include <common.h> > >>> #include <asm/io.h> > >>> #include <asm/arch/sysmap.h> > >>> +#include <asm/kona-common/clk.h> > >>> > >>> #include "dwc2_udc_otg_priv.h" > >>> #include "bcm_udc_otg.h" > >>> > >>> void otg_phy_init(struct dwc2_udc *dev) > >>> { > >>> + /* turn on the USB OTG clocks */ > >>> + clk_usb_otg_enable((void *)HSOTG_BASE_ADDR); > >> > >> I _think_ this driver is used on RPi too, did you compile test it there? > > > > no, it is not - the only place this is used is: > > drivers/usb/gadget/Makefile:obj-$(CONFIG_USB_GADGET_BCM_UDC_OTG_PHY) > > += bcm_udc_otg_phy.o > > include/configs/bcm28155_ap.h:#define CONFIG_USB_GADGET_BCM_UDC_OTG_PHY > > Got it, thanks for checking. > > Do you want me to pick this up via u-boot-usb or shall this go via some > other tree as a series ? > I don't have any preference - what is the best way to get my outstanding patches applied? Thanks, Steve
> > Thanks, Steve > > PS. > > "rpi" and "rpi_2" both build successfully.... > > > >> > >> > >>> /* set Phy to driving mode */ > >>> wfld_clear(HSOTG_CTRL_BASE_ADDR + HSOTG_CTRL_PHY_P1CTL_OFFSET, > >>> HSOTG_CTRL_PHY_P1CTL_NON_DRIVING_MASK); > >>> > >> > >> > >> -- > >> Best regards, > >> Marek Vasut > > > -- > Best regards, > Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot