Hi Rob,
On Fri, 20 Feb 2015 08:54:56 -0600
Rob Herring <rob.herr...@linaro.org> wrote:
> On Wed, Feb 18, 2015 at 1:52 PM, Dileep Katta <dileep.ka...@linaro.org> wrote:
> > This patch adds functionality to getvar command to get the userdata
> > partition
> > size.
>
> This is non-standard and doesn't scale to other partitions. There is
> already a standard var "partition-size:<part name>". There is also
> "partition-type:<part name>" which probably needs to be supported as
> well. It would probably be good to have generic code to retrieve
> fastboot variables from a u-boot environment variables. Something like
> this:
>
> fastboot: allow retrieving fastboot variables from env
>
> Signed-off-by: Rob Herring <r...@kernel.org>
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index 310175a..31e1063 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -364,8 +364,15 @@ static void cb_getvar(struct usb_ep *ep, struct
> usb_request *req)
> else
> strcpy(response, "FAILValue not set");
> } else {
> - error("unknown variable: %s\n", cmd);
> - strcpy(response, "FAILVariable not implemented");
> + char envstr[32];
> + snprintf(envstr, sizeof(envstr) - 1, "fastboot.%s", cmd);
> + s = getenv(envstr);
> + if (s) {
> + strncat(response, s, chars_left);
> + } else {
> + error("unknown variable: %s\n", cmd);
> + strcpy(response, "FAILVariable not implemented");
> + }
> }
> fastboot_tx_write_str(response);
> }
>
I need this feature to expose some uboot variable through 'fastboot
getvar', would you mind if I resend this patch for you?
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
