Hi Stephen, On 16 February 2016 at 16:43, Stephen Warren <swar...@wwwdotorg.org> wrote: > On 02/14/2016 07:16 PM, Simon Glass wrote: >> >> Recent additions of the MMC and DISK uclasses have indicated that it is >> time >> to look at adding a uclass for block devices. This series does this and >> includes a few clean-ups to the partition code also. >> >> A block device is typically a child device of its storage parent. For >> example an MMC device will have a block-device child. A USB storage device >> may have multiple block-device children, one for each LUN. >> >> With this series only USB storage and 'host' are converted over to use the >> new support. Several more remain, including SCSI, IDE and MMC. Each of >> these >> should get its own uclass. >> >> The uclass implements only a few basic features. A few tests are added to >> check that things work as expected. >> >> The code size impact of switching to driver model for block devices is >> small. One benefit is that it becomes possible to enumerate all block >> devices, regardless of their type. > > > This series looks OK, and I would give it an Acked-by, except that it seems > to break DFU to SD card on the 3 systems where I'm running test/py, and even > cause "dhcp" to fail on one of them (that could be either memory corruption > caused by these patches, or pre-existing corruption that these patches > shuffle around in memory so it only now causes a problem). I'll see if I can > bisect these down to a specific patch in the series and see what's up.
It sounds like you found the bug there, and I'll include the fix in v2. Thanks very much for testing this. I will try to get it in very early in the merge window as it is risky. But your automated tests are a big comfort. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
