On Fri, 2016-02-05 at 14:33 +0900, Masahiro Yamada wrote: > >> These build commands are constant (mostly, just concatenating > images, > >> or just copying). No need to use $(call if_changed,...) for them. > > > > > > I disagree, since I believe this change means that if someone /does/ change > > the command in the future (e.g. to replace it with more complex processing, > > or add additional dependencies), then the Makefile will/may not > > automatically rebuild those targets, which is the entire point of using > > if_changed, and is a huge benefit of using Kbuild. > > I do not a strong opinion about this, so > I will drop 3/5 and submit v2.
I think the same logic applies to that part of the change in patch 2 as well. Ian. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot