Dear Ben Warren, In message <4a8c3172.70...@gmail.com> you wrote: > > > - if (!miiphy_link(dev->name, phyadr)) { > > - printf("%s: No link on %s\n", __FUNCTION__, dev->name); > > > Please use __func__ instead. It's defined in C99, while __FUNCTION__ > isn't (or so I've read)
Do we really need the function name at all? This sounds more like a debug message for the developper than a standard error message. > > + /* Wait up to 5s for the link status */ > > + for (i = 0; i < 5; i++) { > > + u16 phyadr; > > > Please put this variable declaration outside of the 'for' loop Why? If it's only used in this block it's actually a good thing to restrict it to this scope. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Man is the best computer we can put aboard a spacecraft ... and the only one that can be mass produced with unskilled labor. -- Wernher von Braun _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot