On Fri, Dec 11, 2015 at 1:24 PM, Marek Vasut <ma...@denx.de> wrote: > On Friday, December 11, 2015 at 03:59:14 PM, Jagan Teki wrote: >> On 11 December 2015 at 02:57, Troy Kisky <troy.ki...@boundarydevices.com> > wrote: >> > If GENMASK is REALLY desired, it should be GENMASK(23,0) >> > But since GENMASK is obviously more confusing, let's just revert. >> > >> > This reverts commit bad490a24212c068c5b718b9189f47ea4075d078. >> >> Sorry, just fix genmask why revert? because driver author has no >> complaint on this, please don't just say simply "more confusing" more >> over I usually prefer reverting bug fix patches. > > I also agree this GENMASK() crap is confusing.
Agreed. A simple proof that this is confusing is that it broke the fsl_qspi.c driver. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
