On 12/01/2015 08:54 AM, Sinan Akman wrote: > > Hi York > > On 01/12/15 11:44 AM, York Sun wrote: >> Sinan, >> >> Thanks for your review. >> >> Yuantian, >> >> You are right about putting things together. We have some macros in wrong >> places, including config.h. If you can, please try to move them into proper >> files, such as immap_lsch3.h. Enabling SATA should be done at board level >> because it depends on the board to have physical connection. > > Just to make this clear one final time, I am not against enabling > SATA at the board level but > my suggestion is to define the SATA register values (which is *not* > board dependent) in the > soc specific header file, then at the board level if SATA is not enabled > we don't use it, if it is > enabled we use it and use the same register values across all boards > with this SoC. That's all. >
Agreed. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
