With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and
becomes BUG_ON((!a) != b).  In this case reading of the function leads to
us wanting to rewrite this as BUG_ON(a != b).

Cc: Prabhakar Kushwaha <prabha...@freescale.com>
Cc: Geoff Thorpe <geoff.tho...@freescale.com>
Cc: Haiying Wang <haiying.w...@freescale.com>
Cc: Roy Pledge <roy.ple...@freescale.com>
Cc: York Sun <york...@freescale.com>
Signed-off-by: Tom Rini <tr...@konsulko.com>
---
 drivers/net/fsl-mc/dpio/qbman_portal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c 
b/drivers/net/fsl-mc/dpio/qbman_portal.c
index 5fa8d95..449ff8a 100644
--- a/drivers/net/fsl-mc/dpio/qbman_portal.c
+++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
@@ -117,7 +117,7 @@ void qbman_swp_mc_submit(struct qbman_swp *p, void *cmd, 
uint32_t cmd_verb)
 {
        uint32_t *v = cmd;
 #ifdef QBMAN_CHECKING
-       BUG_ON(!p->mc.check != swp_mc_can_submit);
+       BUG_ON(p->mc.check != swp_mc_can_submit);
 #endif
        lwsync();
        /* TBD: "|=" is going to hurt performance. Need to move as many fields
-- 
2.6.2

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to