Hi Tom, On 21 November 2015 at 08:22, Tom Rini <tr...@konsulko.com> wrote: > On Sat, Nov 21, 2015 at 10:39:54AM +0800, Thomas Chou wrote: >> Hi Simon, >> >> On 2015年11月21日 08:27, Simon Glass wrote: >> >>I moved it to a macro. >> >>#define CONFIG_SYS_NS16550_CLK get_serial_clock() >> > >> >Ah, we shouldn't do that with driver model. This should be in some >> >sort of clock driver. Perhaps we should leave this serial driver along >> >for now? >> >> I understand a clock driver should be used for driver model. But I >> would suggest that we use this get_serial_clock macro until the >> clock driver for powerpc is ready to get UART clock. This will help >> things moving forwards to driver model. > > Yes, how do you want to proceed here Simon? I have all of these (and a > few other things) build-tested now and will be doing some quick sanity > run time testing later. Thanks!
My first thought would be to leave serial_ppc.c out of the conversion, but that would be tricky given how the series is structured (with the temporary CONFIG). Perhaps a TODO on the #define above since it should be cleaned up, and we want to make sure no one copies it. Since you have it ready I think it should go in, with the TODO if you can manage it. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
