On Sun, Nov 08, 2015 at 05:11:43PM +0200, Nikita Kiryanov wrote:
> The original intention of the mmc load_image() function was to try multiple
> boot modes before failing. This is evident by the lack of break statements
> in the switch, and the following line in the default case:
> puts("spl: mmc: no boot mode left to try\n");
>
> This implementation is problematic because:
> - The availability of alternative boot modes is very arbitrary since it
> depends on the specific order of the switch cases. If your boot mode happens
> to
> be the first case, then you'll have a bunch of other boot modes as
> alternatives.
> If it happens to be the last case, then you have none.
> - Opting in/out is tied to config options, so the only way for you to prevent
> an
> alternative boot mode from being attempted is to give up on the feature
> completely.
> - This implementation makes the code more complicated and difficult to
> understand.
>
> Address these issues by inserting a break statements between the cases to
> make the
> function try only one boot mode.
>
> Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il>
> Cc: Igor Grinberg <grinb...@compulab.co.il>
> Cc: Paul Kocialkowski <cont...@paulk.fr>
> Cc: Pantelis Antoniou <pa...@antoniou-consulting.com>
> Cc: Tom Rini <tr...@konsulko.com>
> Cc: Simon Glass <s...@chromium.org>
> Reviewed-by: Simon Glass <s...@chromium.org>
> Reviewed-by: Tom Rini <tr...@konsulko.com>Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
