On Aug 4, 2009, at 1:07 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
>
> In message <1249352037-25832-1-git-send-email-ga...@kernel.crashing.org 
> > you wrote:
>> Every platform that calls fsl_pci_init calls pci_setup_indirect  
>> before
>> it calls fsl_pci_init.  There isn't any reason to just call it from
>> fsl_pci_init and simplify things a bit.
> ...
>> --- a/include/asm-ppc/fsl_pci.h
>> +++ b/include/asm-ppc/fsl_pci.h
>> @@ -21,7 +21,7 @@
>> #define __FSL_PCI_H_
>>
>> int fsl_pci_setup_inbound_windows(struct pci_region *r);
>> -void fsl_pci_init(struct pci_controller *hose);
>> +void fsl_pci_init(struct pci_controller *hose, u32 cfg_addr, u32  
>> cfg_data);
>
> There will never be any system where 64 bit addresses may be needed?

I thought about this, pci_setup_indirect() takes u32's at this time.   
I'm not sure what the best option is here.

- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to