Dear Scott Wood, In message <20090728202053.ga28...@b07421-ec1.am.freescale.net> you wrote: > > Sorry about that.
No problem. ... > > #define CONFIG_CMD_PING > > diff --git a/include/configs/NETTA2.h b/include/configs/NETTA2.h > > index 167285e..d060cb7 100644 > > --- a/include/configs/NETTA2.h > > +++ b/include/configs/NETTA2.h > > @@ -121,7 +121,6 @@ > > */ > > #include <config_cmd_default.h> > > > > -#define CONFIG_CMD_NAND > > #define CONFIG_CMD_DHCP > > #define CONFIG_CMD_PING > > #define CONFIG_CMD_MII > > Why remove them outright here... Because these are "simple" configurations, and if at a later point of time someone adds CONFIG_CMD_NAND again this is a straightforward thing to do. > > diff --git a/include/configs/NETVIA.h b/include/configs/NETVIA.h > > index b9cf621..a18b480 100644 > > --- a/include/configs/NETVIA.h > > +++ b/include/configs/NETVIA.h > > @@ -107,7 +107,7 @@ > > #define CONFIG_CMD_PING > > > > #if defined(CONFIG_NETVIA_VERSION) && CONFIG_NETVIA_VERSION >= 2 > > -#define CONFIG_CMD_NAND > > +/* #define CONFIG_CMD_NAND */ /* disabled */ > > #endif > > ...but only comment it out here? Because here it's dependent on a specific config option, and when removing the #define, the #if makes no sense any more, and somebody trying to re-add CONFIG_CMD_NAND (without carefully studiyng the git history) would probably need more time to come up with the right solution. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de core error - bus dumped _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
