Robin Getz wrote: > On Sun 26 Jul 2009 07:46, Anatolij Gustschin pondered: ... >> Applied to u-boot-video. Thanks! Note that I had to fix lots >> of style issues before applying. Next time please use >> scripts/checkpatch.pl from the Linux source tree to >> check your patches before submitting them and resolve >> reported issues were it makes sence. Thanks. > > Is there a reason not to include the checkpatch.pl in > http://www.denx.de/wiki/U-Boot/Patches or in the README (in the Submitting > Patches section) if it is going to be a requirement?
It is not a requirement, but would make submitter's and our life easier. Some errors/warnings reported by checkpatch.pl might cause additional confusion as they apply only for Linux patches. In this case I suggested to use checkpatch because v3 of the patch still had style issues pointed out in the comments to the first version. Best regards, Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot