On Thu, 2015-09-17 at 22:36 -0500, Gong Qianyu-B52263 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, September 18, 2015 4:16 AM > > To: Gong Qianyu-B52263 > > Cc: u-boot@lists.denx.de; Hu Mingkai-B21284; Sun York-R58495; Hou > > Zhiqiang-B48286; Song Wenbin-B53747; Xie Shaohui-B21989; Wood Scott- > > B07421 > > Subject: Re: [Patch v2 11/16] armv8/ls1043ardb: Add nand boot support > > > > On Thu, 2015-09-17 at 15:06 +0800, Gong Qianyu wrote: > > > > > > > > > > > +/* NAND SPL */ > > > +#ifdef CONFIG_NAND_BOOT > > > +#define CONFIG_SPL_PBL_PAD > > > +#define CONFIG_SPL_FRAMEWORK > > > +#define CONFIG_SPL_LDSCRIPT "arch/arm/cpu/armv8/u-boot- > > spl.lds" > > > +#define CONFIG_SPL_TARGET "u-boot-with-spl.bin" > > > +#define CONFIG_SPL_LIBCOMMON_SUPPORT > > > +#define CONFIG_SPL_LIBGENERIC_SUPPORT #define CONFIG_SPL_ENV_SUPPORT > > > +#define CONFIG_SPL_WATCHDOG_SUPPORT #define CONFIG_SPL_I2C_SUPPORT > > > +#define CONFIG_SPL_SERIAL_SUPPORT #define > > > +CONFIG_SPL_MPC8XXX_INIT_DDR_SUPPORT > > > +#define CONFIG_SPL_NAND_SUPPORT > > > +#define CONFIG_SPL_DRIVERS_MISC_SUPPORT > > > +#define CONFIG_SPL_TEXT_BASE 0x10000000 > > > +#define CONFIG_SPL_MAX_SIZE 0x1a000 > > > +#define CONFIG_SPL_STACK 0x1001d000 > > > +#define CONFIG_SPL_PAD_TO 0x1c000 > > > +#define CONFIG_SYS_NAND_U_BOOT_OFFS CONFIG_SPL_PAD_TO #define > > > +CONFIG_SYS_NAND_U_BOOT_SIZE (640 << 10) > > > > You made the U-Boot size be block aligned (assuming 128k block size, > > which the SoC common file should not do), but its offset is not. > > > > -Scott > > Eh, yes. The CONFIG_SPL_PAD_TO should be block aligned and put to board > specific file assuming different NAND chips.
Yes. > That reminds me. SPL and U-Boot size should be block aligned, so it is with > the env size. Right? The environment should have a full block reserved to it, but the actual environment size does not need to take up the full block. Typically U-Boot environments are smaller than a flash block, probably to reduce the amount of CRC that needs to be calculated. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
