Eric Bénard wrote: > Ben Warren wrote : >> This patch has many coding style violations that haven't been >> addressed, so it can't go in. I"m not a fan of the piece-meal PHY >> implementation > > coding style violations should be fixed in v3 / > http://www.mail-archive.com/u-boot@lists.denx.de/msg18068.html > > Eric Not quite. Camel-case function names like 'ks8721_IsPhyConnected' violate the coding style. regards, Ben _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
- Re: [U-Boot] [PATCH 1/1] Add support... Jean-Christophe PLAGNIOL-VILLARD
- [U-Boot] [PATCH 1/1] Add support... Eric Benard
- Re: [U-Boot] [PATCH 1/1] Add... Wolfgang Denk
- [U-Boot] [PATCH v3] Add ... Eric Benard
- Re: [U-Boot] [PATCH... Jean-Christophe PLAGNIOL-VILLARD
- Re: [U-Boot] [PATCH... Wolfgang Denk
- Re: [U-Boot] [PATCH... Jean-Christophe PLAGNIOL-VILLARD
- Re: [U-Boot] [PATCH 1/1] Add support for ... Jean-Christophe PLAGNIOL-VILLARD
- Re: [U-Boot] [PATCH 1/1] Add support... Ben Warren
- Re: [U-Boot] [PATCH 1/1] Add sup... Eric Bénard
- Re: [U-Boot] [PATCH 1/1] Add... Ben Warren
- [U-Boot] [PATCH] Add sup... Eric Benard
- Re: [U-Boot] [PATCH... Jean-Christophe PLAGNIOL-VILLARD
- Re: [U-Boot] [PATCH... Eric Bénard
- [U-Boot] [PATCH v5]... Eric Benard
- Re: [U-Boot] [PATCH... Jean-Christophe PLAGNIOL-VILLARD
- Re: [U-Boot] [PATCH... Wolfgang Denk
- Re: [U-Boot] [PATCH... Wolfgang Denk
- Re: [U-Boot] [PATCH... Dirk Behme
- Re: [U-Boot] [PATCH... Wolfgang Denk
- [U-Boot] [PATCH v6]... Eric Benard