Hi Lukasz, On 29 August 2015 at 06:09, Lukasz Majewski <l.majew...@majess.pl> wrote: > On Fri, 28 Aug 2015 17:21:51 -0600 > Simon Glass <s...@chromium.org> wrote: > >> Hi Lukasz, >> >> On 28 August 2015 at 07:50, Lukasz Majewski <l.majew...@samsung.com> >> wrote: >> > >> > The timeout error for DW MMC transfer should be visible on the >> > u-boot console to speed up the process of debugging. >> > >> > Signed-off-by: Lukasz Majewski <l.majew...@samsung.com> >> > Cc: Tom Rini <tr...@konsulko.com> >> > Cc: Simon Glass <s...@chromium.org> >> > --- >> > drivers/mmc/dw_mmc.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Can this be reported at the command line level instead? > > With my setup - dfu tests - I didn't receive any error/information > about the MMC (SD Card to be precise) timeout. > > (I would expect MMC subsystem to return -ETIMEOUT and then this error > would be propagated to dfu and stop execution of the dfu command). > > This didn't work and hence should be scrutinized.
Agreed. > >> It feels wrong >> to be printing errors in a driver. > > If this information would be printed on the console I might have > noticed it immediately and save some time for debugging. > >> Also, why does it return TIMEOUT >> instead of -ETIMEOUT? > > Good question. It looks likes mmc.h has its own errors (NO_CARD_ERR, etc.). I suspect these could be converted to use standard errors. Anyway your question remains. A driver error should be reported by the caller. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
