Hi Bin, On 21 August 2015 at 01:18, Bin Meng <bmeng...@gmail.com> wrote: > The existing i8042 keyboard controller driver has some issues. > First of all, it does not issue a self-test command (0xaa) to the > controller at the very beginning. Without this, the controller > does not respond any command at all. Secondly, it initializes
a few nits "does not response to any command" > the configuration byte reigster to turn on keyboard's interrupt, turn on the keyboard's interrupt > which is not allowed as U-Boot we don't normally enable interrupt. as U-Boot does not normally allow interrupts to be processed. > Finally, at the end of the initialization routine, it wrongly > sets the controller to disable all interfaces including both > keyboard and mouse. > > Signed-off-by: Bin Meng <bmeng...@gmail.com> > Acked-by: Simon Glass <s...@chromium.org> > > --- > > Changes in v2: > - Reorder this patch to follow the i8042 driver clean up patches > > drivers/input/i8042.c | 43 +++++++++++++++++++++---------------------- > 1 file changed, 21 insertions(+), 22 deletions(-) I am amazed this code actually works! But at least on chromebook_link, it does. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
