> -----Original Message----- > From: Vladimir Zapolskiy [mailto:v...@mleia.com] > Sent: 12-Aug-15 8:05 PM > > Hi Sylvain, > > On 12.08.2015 23:00, LEMIEUX, SYLVAIN wrote: > > Hi Vladimir and Marek, > > > >> -----Original Message----- > >> From: Vladimir Zapolskiy [mailto:v...@mleia.com] > >> Sent: 12-Aug-15 1:55 PM > >> > >> Hi Sylvain, > >> > >> On 10.08.2015 15:16, slemieux.t...@gmail.com wrote: > >>> From: Sylvain Lemieux <slemi...@tycoint.com> > >>> > >>> Incorporate USB driver from legacy LPCLinux NXP BSP. > >>> The files taken from the legacy patch are: > >>> - lpc32xx USB driver > >>> - lpc3250 header file USB registers definition. > >>> > >>> The legacy driver was updated and clean-up as part of the integration > >>> with the latest u-boot. > >>> > >>> Signed-off-by: Sylvain Lemieux <slemi...@tycoint.com> > >>> --- > > [snip] > > >>> + } > >>> + > >>> + /* Configure ISP1301 */ > >>> + isp1301_configure(); > >> > >> Not sure if there are any LPC32xx boards with USB host/device, but > >> without ISP1301 phy. Let it be here until such a board emerges, if Marek > >> does not object. > >> > >> In general I wonder, won't drivers/usb/phy/ be a better place for this > >> driver or bigger part of it? > > > > The Embedded Artists LPC3250 OEM Board is having the USB with the ISP1301; > > http://www.embeddedartists.com/products/kits/lpc3250_kit.php > > The legacy NXP LPC32xx BSP included board support files for it. > > > > it seems to be a usual design pattern, my devkit3250 board also has > ISP1301 phy. The question is if fusion of a particular external phy > device driver and a particular host device driver are permitted in form > of a host driver only. > > This is a question in area of device driver(s) maintenance, therefore > Marek should rule it. For me as a user I'm satisfied with the approach, > when on-SoC host device and external phy device share one driver for > both. Just when an LPC32xx powered board with USB emerges without > ISP1301 phy or other way round ISP1301 phy is used in junction with > another host/device, this time the driver will be split. > The maintainer, Marek, previously ack the patch; https://www.mail-archive.com/u-boot@lists.denx.de/msg180934.html I am assuming it is OK to keep the current approach.
I will add your tested, as per this message listed below and the ack from Marek when I submit revision 7, later today. https://www.mail-archive.com/u-boot@lists.denx.de/msg180934.html Sylvain Lemieux > -- > With best wishes, > Vladimir ________________________________ This e-mail contains privileged and confidential information intended for the use of the addressees named above. If you are not the intended recipient of this e-mail, you are hereby notified that you must not disseminate, copy or take any action in respect of any information contained in it. If you have received this e-mail in error, please notify the sender immediately by e-mail and immediately destroy this e-mail and its attachments. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
