On Wednesday, August 12, 2015 at 11:35:25 PM, Vladimir Zapolskiy wrote: > On 12.08.2015 22:47, LEMIEUX, SYLVAIN wrote: > > Hi Vladimir, > > > >> -----Original Message----- > >> From: Marek Vasut [mailto:ma...@denx.de] > >> Sent: 12-Aug-15 3:42 PM > >> > >> On Wednesday, August 12, 2015 at 07:55:29 PM, Vladimir Zapolskiy wrote: > >>> Hi Sylvain, > >>> > >>> On 10.08.2015 15:16, slemieux.t...@gmail.com wrote: > >>>> From: Sylvain Lemieux <slemi...@tycoint.com> > >>>> > >>>> Incorporate USB driver from legacy LPCLinux NXP BSP. > >>>> The files taken from the legacy patch are: > >>>> - lpc32xx USB driver > >>>> - lpc3250 header file USB registers definition. > >>>> > >>>> The legacy driver was updated and clean-up as part of the integration > >>>> with the latest u-boot. > >>>> > >>>> Signed-off-by: Sylvain Lemieux <slemi...@tycoint.com> > >> > >> [...] > >> > >>>> +static int wait_for_bit(void *reg, const u32 mask, bool set) > >>>> +{ > >>> > >>> (set == false) argument is not in use, and hence there is a piece of > >>> dead code in the function. > >> > >> I'd prefer this to be the way it is, since this function can be > >> extracted and made into generic code (probably in subsequent patch). > > > > Vladimir, are you OK with keeping the code as-is? > > It will make it easier when we attempt to create a generic > > "wait_for_bit()" function. > > Okay, if maintainer says, let it remain :)
Heh, thanks :-) Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
