Stephen,
> -----Original Message-----
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Wednesday, July 22, 2015 10:57 AM
> To: Tom Warren
> Cc: u-boot@lists.denx.de; Thierry Reding; Stephen Warren;
> tomcwarren3...@gmail.com
> Subject: Re: [U-Boot] [PATCH V2 5/6] P2571: dts: Add DT files for
> Tegra210/P2571 board
>
> On 07/20/2015 01:50 PM, Tom Warren wrote:
> > Based on T124 Venice2. SDMMC1 is SD-card slot.
>
> I would expect the SoC DT file to be part of the previous patch which adds
> Tegra210 support.
>
> I would expect the P2571 file to be part of the next patch which adds
> P2571 board support.
The DT files are split in the same manner as I did for T124/Venice2 back in Jan
of '14, and Dalmore/T114 back in Jan '13. This is the way I've always done it.
But I see the value in having the DTSI file in with the Tegra210 support patch
- I'll move it there.
>
> > diff --git a/arch/arm/dts/tegra124.dtsi b/arch/arm/dts/tegra210.dtsi
>
> I'd expect many more changes in this file, to add the tegra210 compatible
> values to the compatible properties (or replace the tegra124 values with
> tegra210 as appropriate depending on actual HW compatibility).
>
> Also, both #address-cells=<2> and #size-cells=<2> should be present, since
> this
> is a 64-bit SoC. That'd also require that all reg values be updated to
> include 2
> cells for address and size, and the unit address in the node names to be
> updated.
>
> > pwm: pwm@7000a000 {
> > compatible = "nvidia,tegra124-pwm", "nvidia,tegra20-pwm";
> > reg = <0x7000a000 0x100>;
>
> For example, that should probably be:
>
> pwm: pwm@0,7000a000 {
> compatible = "nvidia,tegra210-pwm", "nvidia,tegra20-pwm";
> reg = <0 0x7000a000 0 0x100>;
> }
>
> (Assuming the new PWM HW module is still a 100%-backwards-compatible
> superset of Tegra20 PWM)
>
This was cloned/ported from T124 (32-bit), so it's the first 64-bit Tegra SoC -
I'm not up-to-speed on 64-bit DT requirements. I'll make the changes and see
how it builds/boots.
> Fixing this issue might mean depending on more of Thierry's local 64-bit
> fixes,
> especially w.r.t. DT parsing. I'm not sure.
--
nvpublic
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
