On Monday, June 08, 2015 at 04:05:04 AM, Josh Wu wrote: > Hi, Marek > > On 6/5/2015 9:18 PM, Marek Vasut wrote: > > On Friday, June 05, 2015 at 09:47:30 AM, Josh Wu wrote: > >> Since some driver like ohci, lcd used dcache functions. But some ARM > >> cpu don't implement the invalidate_dcache_range()/flush_dcache_range() > >> functions. > >> > >> To avoid compiling errors this patch adds an weak empty stub function > >> for all ARM cpu. > >> > >> And each cpu can implement its own implementation. If not implemented > >> by default it will use an empty function. > >> > >> Signed-off-by: Josh Wu <josh...@atmel.com> > >> --- > >> > >> Changes in v2: new added > >> > >> arch/arm/lib/cache.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > > > > So, why exactly can't this be entirely common code , but a CPU-specific > > code ? :) > > Do you mean to make those empty functions as common code for all arch > cpu to use?
Yes. > It seems there is no place to put common code for all arch cpu. Isn't that what the common/ directory is for ? ;-) Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
