Hello Stefan,

Stefan Roese wrote:
> On Wednesday 08 July 2009 20:53:58 Wolfgang Denk wrote:
>>> diff --git a/MAKEALL b/MAKEALL
>>> index 41f1445..6c80694 100755
>>> --- a/MAKEALL
>>> +++ b/MAKEALL
[...]
>>> +#define CONFIG_EXTRA_ENV_SETTINGS                                  \
>>> +   "load=tftp 400000 suen3/u-boot.bin\0"                           \
>>> +   "update=nand erase 0 60000;nand write 400000 0 60000\0"         \
>>> +   "upd=run load update\0"                                         \
>>> +   "mtdparts=orion_nand:512k(uboot),5...@512k(env),"               \
>>> +           "2...@1m(kernel),1...@3m(rootfs)\0"                     \
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> ..
>>
>>> +#define MTDPARTS_DEFAULT   "mtdparts=orion_nand:512k(u-boot),"     \
>>> +                                   "256k(env),"            \
>>> +                                   "2m(kernel),"           \
>>> +                                   "16m(rootfs),"          \
>>> +                                   "32m(fs),"              \
>>> +                                   "-(ubifs)"
>> This seems inconsistent to me. How  about  defining  MTDPARTS_DEFAULT
>> first,  and then just inserting the already defined value, so you can
>> be sure that this doesn;t happen again?
> 
> Yes, good catch. Will change. Thanks for spotting.

Maybe you have a look at:

include/configs/km8xx.h

for an example.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to