Hi Joe, On 27 April 2015 at 13:31, Joe Hershberger <joe.hershber...@gmail.com> wrote: > Hi Simon, > > On Mon, Apr 27, 2015 at 2:24 PM, Joe Hershberger > <joe.hershber...@gmail.com> wrote: >> Hi Simon, >> >> On Thu, Apr 23, 2015 at 11:34 PM, Simon Glass <s...@chromium.org> wrote: >>> Hi Joe, >>> >>> On 21 April 2015 at 16:02, Joe Hershberger <joe.hershber...@ni.com> wrote: >>>> The logic to find the whole matching name was split needlessly between >>>> the reverse_strstr function and its caller. Fully contain it to make the >>>> interface for calling it more consistent. >>>> >>>> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com> >>>> --- >>>> >>>> common/env_attr.c | 79 >>>> +++++++++++++++++++++++++++++-------------------------- >>>> 1 file changed, 41 insertions(+), 38 deletions(-) >>>> >>> >>> You could perhaps add some environment tests in test/ for this >>> function, or access it through getenv(), etc. >> >> I'll look into adding some unit tests for the env stuff. > > I'd like to reuse a bit of the unit test code from DM tests... do you > have any plans to generalize some of it? Or should I take a crack at > some of it (that I want to reuse)?
No plans, please go ahead! Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
