On Thu, 2015-04-23 at 11:37 -0600, Simon Glass wrote: > Hi Tom, > > On 22 April 2015 at 08:14, Tom Rini <tr...@konsulko.com> wrote: > > On Tue, Apr 21, 2015 at 12:37:18PM +0900, Masahiro Yamada wrote: > >> Currently, CONFIG_SPL_LIBGENERIC_SUPPORT must be defined > >> to build under lib/ directory for SPL. > >> > >> This directory contains very basic functions such as memcpy, memset > >> in lib/string.c, so it should be very useful for all the boards. > >> > >> Because SPL always enables compiler's garbage collection, this change > >> should not give impact on its memory footprint. > > > > Since we had a recent reminder about > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54303 did you do a size > > check before/after and confirm no change? Thanks! > > With just this patch applied to upstream/master: > > buildman -b try-masa -sS > boards.cfg is up to date. Nothing to do. > Summary of 2 commits for 1075 boards (32 threads, 1 job per thread) > 01: serial: pl01x: fix PL010 regression > blackfin: + bf609-ezkit > powerpc: + taihu ocotea taishan katmai ebony alpr > sh: + sh7753evb sh7785lcr_32bit sh7785lcr > nios2: + nios2-generic > microblaze: + microblaze-generic > openrisc: + openrisc-generic > arm: + openrd_base axm openrd_ultimate openrd_client > tricorder tricorder_flash mx53loco taurus > 02: spl: descend into lib/ for all the SPL boards > powerpc: + P1022DS_36BIT_NAND > powerpc: (for 406/411 boards) spl/u-boot-spl:all +1.3 > spl/u-boot-spl:data +0.4 spl/u-boot-spl:text +0.9 > > So I think it looks fine.
That doesn't look fine -- it looks like this patch broke P1022DS_36BIT_NAND. There are some SPL targets that are very constrained (e.g. 4K) and do not need or want or have room for this stuff. Garbage collection doesn't catch everything. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
