Hello Simon,

On 04/20/2015 08:07 PM, Przemyslaw Marczak wrote:
This driver implements regulator operations for fixed Voltage/Current
value regulators. beside the standard regulator constraints, which are
put into the uclass platform data, a typical fixed regulator node provides
few additional properties like:
- gpio
- gpio-open-drain
- enable-active-high
- startup-delay-us
The only 'gpio' is used by this driver and is kept in structure of type
'fixed_regulator_platdata', as a device platform data (dev->platdata).

The driver implements:
- get_value
- get_current
- get_enable
- set_enable

The regulator calls and commands can be used for fixed-regulator devices,
and the proper error will be returned for prohibited.

Signed-off-by: Przemyslaw Marczak <p.marc...@samsung.com>


I missed the separation (---) here and I see that you add ACK below the changes.
Could you remove them from the tree?

Changes v3:
- new file
- Kconfig add fixed-regulator entry

Changes V4:
- move DM_REGULATOR_FIXED Kconfig entry from: drivers/power/Kconfig to
   drivers/power/regulator/Kconfig
- regulator/fixed.c: adjust to use of uclass platdata and device platdata
- regulator/fixed.c: includes cleanup
- regulator/fixed.c: fix gpio request
- add binding info
---
  doc/device-tree-bindings/regulator/fixed.txt |  38 ++++++++
  drivers/power/regulator/Kconfig              |   8 ++
  drivers/power/regulator/Makefile             |   1 +
  drivers/power/regulator/fixed.c              | 126 +++++++++++++++++++++++++++
  4 files changed, 173 insertions(+)
  create mode 100644 doc/device-tree-bindings/regulator/fixed.txt
  create mode 100644 drivers/power/regulator/fixed.c

Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marc...@samsung.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to