On Wednesday 08 July 2009 07:52:27 Prafulla Wadaskar wrote: > > > > > +/* > > > > > + * Commands configuration > > > > > + */ > > > > > > > > please include config_cmd_default.h > > > > > > Hi Jean > > > I do not want to include config_cmd_default.h All commands in this > > > file are not supported/required for this board. > > > > include/config_cmd_default.h > > > > please include this one and undef what you do not needis > > Hi Jean, > Total 13 commands used for this board out of which only 7 are configured in > config_cmd_default.h. There are total 20 commands defined in > config_cmd_default.h i.e. I need to undef 13 commands This will add ~15 > lines to the code unnecessarily. > Secondly config_cmd_default.h may be updated frequently for commands > addition, which may not be supported/required on this board. Then again we > have to apply undef patch for this board. Is it mandatory to include this > file?
It's not mandatory. But one advantage is that by using this file (and not uncommenting most of the stuff) all boards have the same look-and-feel by supporting the same command sets. But your command selection looks fine and I think that it's ok to define then the way you did. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
