> -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com] > Sent: Wednesday, July 08, 2009 2:00 AM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; > Ronen Shitrit > Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board support > > On 00:26 Tue 07 Jul , Prafulla Wadaskar wrote: > > > > > > > -----Original Message----- > > > From: Jean-Christophe PLAGNIOL-VILLARD > > > [mailto:plagn...@jcrosoft.com] > > > Sent: Saturday, July 04, 2009 5:16 AM > > > To: Prafulla Wadaskar > > > Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan > Sarnaik; Ronen > > > Shitrit > > > Subject: Re: [U-Boot] [PATCH v5 6/6] Marvell Sheevaplug Board > > > support > > > > > <snip....> > > > > +#define CONFIG_SYS_PROMPT "Marvell>> " /* > > > Command Prompt */ > > > > +#define CONFIG_SYS_CBSIZE 1024 /* Console I/O > > > Buff Size */ > > > > +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE \ > > > > + +sizeof(CONFIG_SYS_PROMPT) + 16) > /* Print Buff */ > > > > +/* > > > > + * Commands configuration > > > > + */ > > > please include config_cmd_default.h > > Hi Jean > > I do not want to include config_cmd_default.h All commands in this > > file are not supported/required for this board. > include/config_cmd_default.h > > please include this one and undef what you do not needis Hi Jean, Total 13 commands used for this board out of which only 7 are configured in config_cmd_default.h. There are total 20 commands defined in config_cmd_default.h i.e. I need to undef 13 commands This will add ~15 lines to the code unnecessarily. Secondly config_cmd_default.h may be updated frequently for commands addition, which may not be supported/required on this board. Then again we have to apply undef patch for this board. Is it mandatory to include this file?
Regards.. Prafulla . . > > Best Regards, > J. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
