Hi Joe, On 1 March 2015 at 14:53, Joe Hershberger <joe.hershber...@gmail.com> wrote: > Hi Simon, > > > On Sun, Mar 1, 2015 at 12:07 PM, Simon Glass <s...@chromium.org> wrote: >> >> Hi Joe, >> >> On 24 February 2015 at 17:02, Joe Hershberger <joe.hershber...@ni.com> >> wrote: >> > netretry previously would only retry in one specific case (your MAC >> > address is not set) and no other. This is basically useless. In the DM >> > implementation for eth it turns this into a completely useless case >> > since an un-configured MAC address results in not even entering the >> > NetLoop. The behavior is now changed to retry any failed command >> > (rotating through the eth adapters if ethrotate != no). >> > >> > It also defaulted to retry forever. It is now changed to default to not >> > retry >> >> That last bit seems like a big change. Does it mean that if I forget >> to plug in the Ethernet it might not recover? > > It seems like it at face value, but this actually is far closer to > maintaining existing behavior. > > As described in the first paragraph, only a missing MAC address would be > retried. all other forms of failure (unplugged Ethernet, for instance) would > just error out. This provides a way to retry if that is a behavior you want. > Most times if you ping an address, for instance, you would expect your > script to get a failure code, not for the ping to be attempted on a > different interface (which would become the new default behavior without > this env var default also changing).
Thanks for explaining this. Reviewed-by: Simon Glass <s...@chromium.org> Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
