Hi Marek, > On Tuesday, February 24, 2015 at 02:21:40 PM, Kishon Vijay Abraham I > wrote: > > Hi, > > > > On Monday 23 February 2015 08:29 PM, Marek Vasut wrote: > > > On Monday, February 23, 2015 at 07:19:03 AM, Kishon Vijay Abraham > > > I wrote: > > >> Hi, > > >> > > >> On Monday 16 February 2015 04:02 PM, Lukasz Majewski wrote: > > >>> Hi Kishon, Marek > > >>> > > >>>> Added a header file to include various linux specific APIs like > > >>>> pr_debug, WARN_ WARN_ON_ONCE etc.. in order to avoid > > >>>> compilation error while building dwc3 driver. > > >>>> > > >>>> Signed-off-by: Kishon Vijay Abraham I <kis...@ti.com> > > >>>> --- > > >>>> > > >>>> drivers/usb/dwc3/linux-compat.h | 30 > > >>>> ++++++++++++++++++++++++++++++ 1 file changed, 30 > > >>>> insertions(+) create mode 100644 > > >>>> drivers/usb/dwc3/linux-compat.h > > >>>> > > >>>> diff --git a/drivers/usb/dwc3/linux-compat.h > > >>>> b/drivers/usb/dwc3/linux-compat.h new file mode 100644 > > >>>> index 0000000..58c4716 > > >>>> --- /dev/null > > >>>> +++ b/drivers/usb/dwc3/linux-compat.h > > >>>> @@ -0,0 +1,30 @@ > > >>>> +/** > > >>>> + * linux-compat.h - DesignWare USB3 Linux Compatibiltiy > > >>>> Adapter Header > > >>>> + * > > >>>> + * Copyright (C) 2015 Texas Instruments Incorporated - > > >>>> http://www.ti.com > > >>>> + * > > >>>> + * Authors: Kishon Vijay Abraham I <kis...@ti.com> > > >>>> + * > > >>>> + * Taken from Linux Kernel v3.16 (drivers/usb/dwc3/core.c) > > >>>> and ported > > >>>> + * to uboot. > > >>>> + * > > >>>> + * SPDX-License-Identifier: GPL-2.0 > > >>>> + * > > >>>> + */ > > >>>> + > > >>>> +#ifndef __DWC3_LINUX_COMPAT__ > > >>>> +#define __DWC3_LINUX_COMPAT__ > > >>>> + > > >>>> +#define pr_debug(format) debug(format) > > >>>> +#define WARN(val, format, arg...) debug(format, ##arg) > > >>>> +#define WARN_ON_ONCE(val) debug("Error %d\n", > > >>>> val) + > > >>>> +#define BUILD_BUG_ON_NOT_POWER_OF_2(n) > > >>>> + > > >>>> +static inline size_t strlcat(char *dest, const char *src, > > >>>> size_t n) +{ > > >>>> + strcat(dest, src); > > >>>> + return strlen(dest) + strlen(src); > > >>>> +} > > >>>> + > > >>>> +#endif > > >>> > > >>> Similar file has been already added to u-boot. > > >>> Please look into ./drivers/usb/musb-new/linux-compat.h > > >>> > > >>> @Marek - maybe it is time to have a common one? > > >> > > >> Can we do this separately? > > > > > > Would it be too much of a hassle to make a common one please ? > > > > Okay. I sent a new patch which should be applied on top of my v2 > > that removes creating a new linux compatibility header file for > > dwc3. > > Well you know that such patch should really go in first, right ? But > it's pretty pointless to push you to rework the entire thing I'd say, > so let's just apply all this stuff as is. Lukasz, do you plan to pick > it all up?
It thought that it would be directly taken to -usb tree. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
