On Tue, Feb 3, 2015 at 4:38 PM, Simon Glass <[email protected]> wrote: > +Masahiro > > Hi Chris, > > On 3 February 2015 at 00:42, Chris Kuethe <[email protected]> wrote: >> Discovered while experimenting with signature checking on vexpress >> which doesn't typically use DM. Rather than complaining about unmet >> dependencies it might be better to enable those them. >> >> --- >> lib/rsa/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig >> index 1268a1b..4db5da4 100644 >> --- a/lib/rsa/Kconfig >> +++ b/lib/rsa/Kconfig >> @@ -2,6 +2,7 @@ config RSA >> bool "Use RSA Library" >> select RSA_FREESCALE_EXP if FSL_CAAM >> select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP >> + select DM >> help >> RSA support. This enables the RSA algorithm used for FIT image >> verification in U-Boot. > > I wonder whether 'depends on DM' might be better? It seems odd to have > the tail wagging the dog. > > Regards, > Simon
No, that would not be better because a few lines down, RSA_SOFTWARE_EXP and RSA_FREESCALE_EXP both say "depends on DM" but they don't actually enable it if they need it. As a user, my expectation is that when I turn on some high level feature, that will enable all of its lower level dependencies. Would it be less strange to make FIT_SIGNATURE turn on DM instead of RSA? -- GDB has a 'break' feature; why doesn't it have 'fix' too? _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
