Hi Stefano,

On 01/22/2015 11:58 AM, Stefano Babic wrote:

Hi Nikita,

On 14/01/2015 09:42, Nikita Kiryanov wrote:
Add compulab logo and display it on boot.

Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il>
Cc: Stefano Babic <sba...@denx.de>
Cc: Igor Grinberg <grinb...@compulab.co.il>
---
  include/configs/cm_fx6.h |   3 +++
  tools/logos/compulab.bmp | Bin 0 -> 31810 bytes
  2 files changed, 3 insertions(+)
  create mode 100644 tools/logos/compulab.bmp

diff --git a/include/configs/cm_fx6.h b/include/configs/cm_fx6.h
index a9f33a9..5d0d303 100644
--- a/include/configs/cm_fx6.h
+++ b/include/configs/cm_fx6.h
@@ -306,4 +306,7 @@
  #define CONFIG_CONSOLE_MUX
  #define CONFIG_VIDEO_SW_CURSOR

+#define CONFIG_VIDEO_LOGO
+#define CONFIG_VIDEO_BMP_LOGO
+

This is a general question, not strictly related to the patch. You add
with the series a way to get splash screen from multiple sources. I have
often (I know we are talking about different things..) used splash
screen as a way to add a logo, without the necessity to link the image
to the code. I think also that the way with logo does not scale well,

Why not?

and we cannot merge in mainline tons of images - they have nothing to do
with u-boot sources.

Storing graphics that are part of a program in the program's repository is a
common practice, why should U-Boot be different?


Why is not enough for you to use the splash screen functionality ? IMHO
it is much more flexible as using the logo, and there is no need to link
it against the code.

We are interested in the behavior that VIDEO_LOGO provides: that the logo
remains visible on screen and coexists with the frame buffer console, and that
no manual installation is required.


Best regards,
Stefano Babic


--
Regards,
Nikita Kiryanov
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to