Stefan Roese wrote: > On Monday 22 June 2009 20:12:11 Dirk Behme wrote: >>>> 1. This preprocessor warning is annoying. Why not enable it in all >>>> configs where needed and then remove this warning here? >>> I could have done that, but this would not have been so easy. Especially >>> with so many new board ports pending in the u-boot-arch/next branches at >>> that time. And upcoming board ports would probably fallen through the >>> crack as well. So I decided to do it this way. >> Is this a long term solution or only waiting for all u-boot-arch/next >> branches to be merged? > > I don't understand this question. The current code with this check is > available in mainline. Or not?
Sorry, yes, but you mentioned above pending boards and not merged next branches. So my question was if you plan to change the warning after all pending boards and next branches are merged. >> For a long term solution this would be annoying. Maybe we can change >> this after merge window closed? > > Why? There could still be new board ports using this NAND code without > defining this 64bit printf format option. I don't think this check really > hurts. Because every non-U-Boot expert who just downloads recent git and compiles it will get the warning and will wonder if something is wrong or not. So yes, the check doesn't hurt, but the warning might confuse the users, which are non-experts. It's similar to the "WARNING - bad CRC or NAND, using default environment." runtime warning. There are tons on questions on various mailing lists if this is an error or not ;) > We could get rid of it of course if we would enable this 64bit printf format > on all platforms and removed this option completely. This would cost a bit of > image size but would make things easier/simpler. Just my 0.02$... For OMAP3 I would enabled this option, independent of image size, just to get rid of the warning. Best regards Dirk _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
