Hi Stefan, please leave the code as is. It is already used in a project and so modifying the parameter type may no change.
On Friday 05 June 2009 05:39, Stefan Roese wrote: > Hi Matthias, > > On Thursday 04 June 2009 19:40:19 Matthias Fuchs wrote: > > doen't it make sense to use/extend the code from > > board/esd/common/cmd_loadpci.c in stead it copying this code? Even that > > code is running on 4xx only, it should be simple to modify it for cpci750. > > Adding support for bootvx should be simple also. > > I thought about this too but didn't do it mainly because of those reasons: > > a) As you already mentioned the current code in common is 4xx specific. But easy to adapt :-) > > b) The parameters used to identify the image type are incompatible on > both platforms. "1" is used for booting a script on 4xx and VxWorks > on CPCI750. > > c) I have no means of testing any changes in this code on 4xx and/or > 750. > > So if you still think this should be unified then I need your assistance > here. Of course I can do such testing on 4xx hardware. > You would need to help me testing those changes on both platforms. Please let > me know if you can do this. But let's shutdown this discussion. Matthias _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
