Hi, On 4 October 2014 11:29, Simon Glass <s...@chromium.org> wrote:
> This series adds driver model support for serial and GPIO for sunxi. Since > I only have a sun7i board to test with, I have added a new config for the > pcDuino3, which uses device tree and driver model. This should make it > fairly easy to enable for the other boards at some point. > > Now that we have about 5 GPIO drivers it is clear that the request()/free() > logic should be in the uclass rather than the driver. So far drivers don't > have to do anything in those methods except adjust pin configuration. > Patches are included to make this change, including removing the redundant > code in the various GPIO drivers. The sunxi driver works the same way. > > So far at least GPIO drivers don't tend to have anything special to report > for the 'gpio status' command. Partly this is because we only support a > simple concept of GPIOs so far (no drive strength, function selection, > etc.) but even if this were to be supported it would be better to handle > it generically where possible. So the get_state() call can be replaced with > a generic one in the uclass. This can be implemented with the existing > uclass interface: get_function() to find out if the pin is set as an input, > output or not a GPIO, and get_value() to find its value. > > As a result, it is safe to remove the get_state() method, and this series > does that also. > > This series is available at u-boot-dm/sunix-working. > Any more comments on this series please? I have a few nits so could respin. Regards, Simon
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
