On 08/13/14 15:55, Igor Grinberg wrote:
> Hi Nikita,
>
> Several comments below in addition to Simon's.
>
> On 08/11/14 19:22, Nikita Kiryanov wrote:
>> Add initial support for Compulab CM-FX6 CoM.
>> Support includes MMC, SPI flash, and SPL with dynamic DRAM detection.
>>
>> Cc: Igor Grinberg <grinb...@compulab.co.il>
>> Cc: Stefano Babic <sba...@denx.de>
>> Cc: Tom Rini <tr...@ti.com>
>> Cc: Marek Vasut <ma...@denx.de>
>> Acked-by: Marek Vasut <ma...@denx.de>
>> Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il>
>> ---
[...]
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> + "kernel=uImage-cm-fx6\0" \
>> + "autoload=no\0" \
>> + "loadaddr=0x10800000\0" \
>> + "fdtaddr=0x11000000\0" \
>> + "console=ttymxc3,115200\0" \
>> + "ethprime=FEC0\0" \
>> + "bootscr=boot.scr\0" \
>> + "bootm_low=18000000\0" \
>> + "video_hdmi=mxcfb0:dev=hdmi,1920x1080M-32@50,if=RGB32\0" \
>> + "video_dvi=mxcfb0:dev=dvi,1280x800M-32@50,if=RGB32\0" \
>> + "fdtfile=cm-fx6.dtb\0" \
>> + "doboot=bootm ${loadaddr}\0" \
>> + "loadfdt=false\0" \
>> + "setboottypez=setenv kernel zImage-cm-fx6;" \
>> + "setenv doboot bootz ${loadaddr} - ${fdtaddr};" \
>> + "setenv loadfdt true;\0" \
>> + "setboottypem=setenv kernel uImage-cm-fx6;" \
>> + "setenv doboot bootm ${loadaddr};" \
>> + "setenv loadfdt false;\0"\
>> + "run_eboot=echo Starting EBOOT ...; "\
>> + "mmc dev ${mmcdev} && " \
>> + "mmc rescan && mmc read 10042000 a 400 && go 10042000\0" \
>> + "mmcdev=2\0" \
>> + "mmcroot=/dev/mmcblk0p2 rw rootwait\0" \
>> + "loadmmcbootscript=fatload mmc ${mmcdev} ${loadaddr} ${bootscr}\0" \
>
> Can we switch to use load instead of fatload?
>
>> + "mmcbootscript=echo Running bootscript from mmc ...; "\
>> + "source ${loadaddr}\0" \
>> + "mmcargs=setenv bootargs console=${console} " \
>> + "root=${mmcroot} " \
>> + "${video}\0" \
>> + "mmcloadkernel=fatload mmc ${mmcdev} ${loadaddr} ${kernel}\0" \
>> + "mmcloadfdt=fatload mmc ${mmcdev} ${fdtaddr} ${fdtfile}\0" \
>> + "mmcboot=echo Booting from mmc ...; " \
>> + "run mmcargs; " \
>> + "run doboot\0" \
>> + "nandroot=/dev/mtdblock4 rw\0" \
>> + "nandrootfstype=ubifs\0" \
>> + "nandargs=setenv bootargs console=${console} " \
>> + "root=${nandroot} " \
>> + "rootfstype=${nandrootfstype} " \
>> + "${video}\0" \
>> + "nandloadfdt=nand read ${fdtaddr} 780000 80000;\0" \
>> + "nandboot=echo Booting from nand ...; " \
>> + "run nandargs; " \
>> + "nand read ${loadaddr} 0 780000; " \
>> + "if ${loadfdt}; then " \
>> + "run nandloadfdt;" \
>> + "fi; " \
>> + "run doboot\0" \
I think, if we add NAND support in a separate patch, then probably
it will be better also to add nand boot related environment stuff
along with the NAND support.
>> + "boot=mmc dev ${mmcdev}; " \
>> + "if mmc rescan; then " \
>> + "if run loadmmcbootscript; then " \
>> + "run mmcbootscript;" \
>> + "else " \
>> + "if run mmcloadkernel; then " \
>> + "if ${loadfdt}; then " \
>> + "run mmcloadfdt;" \
>> + "fi;" \
>> + "run mmcboot;" \
>> + "fi;" \
>> + "fi;" \
>> + "fi;"
Also, you add NAND boot commands neither here, nor in the NAND
support patch. Can we have them too? Please?
--
Regards,
Igor.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
