On Fri, 2014-06-20 at 16:29 +0300, Ivan Khoronzhuk wrote:
> On 06/20/2014 04:00 AM, Scott Wood wrote:
> > On Fri, May 16, 2014 at 09:26:36PM +0300, Khoronzhuk, Ivan wrote:
> >> +                  } else {
> >> +                          printf("Setting current device"
> >> +                                 " to ecc layout %d FAILED!\n", idx);
> > Don't wrap user-visible strings (checkpatch should have warned you about
> > this).
> 
> For user's eyes it's not wrapped.

That's not the point.  Wrapping it in the source means the user can't
grep for the string.  Checkpatch should have issued a warning about
this.  This is an exception to the 80 column rule.

-Scott


_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to