On 06/12/2014 01:17 AM, Lukasz Majewski wrote: > Stephen Warren wrote: ... >> Here's how I'd love to see the dfu command work. It would take a bit >> of refactoring of the code, and a change to the format of the >> dfu_alt_info variable and "dfu" command parameters. Perhaps we could >> have an option to the "dfu" command saying which cmdline style the >> user is using? >> >> dfu_alt_info = setting [; setting]* >> >> setting = mmc_format | nand_format | ram_format | fs_format >> >> mmc_format = "mmc" device_id hwpart_num start_sector sector_count >> >> nand_format = "nand" device_id start_sector sector_count >> >> ram_format = "ram" start_address byte_count >> >> fs_format = "fs" fs_device_type fs_device_id filename > > I think that the fs also need fs_device_id and fs_partition.
I would expect fs_device_id to include the partition information. Shell commands such as ls and load use the following format for the device ID: controller_id[.hw_partition][:sw_partition] (with support for the .hw_partition field being part of a patch I sent to get_device_and_partition() within the last few weeks). Hence, we don't need separate fields for this. This proposal would unify the way ls/load/dfu specified devices. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
