Hello Wolfgang, Stefan, Wolfgang Denk wrote:
> In message <200905141613.20127...@denx.de> you wrote: >>> If this should be the highest level in the call chain, then any >>> conditional calling should be done here. >> OK, I can move the conditional calling to this level. > > I'm not sure. > >>> But - don't we already have >>> a board_video_init() which could return proper status to abort >>> initialization? >> This is only implemented for some video drivers (SM501, SED13806, MB826xx) >> to >> return the base address for the graphics chip. The PCI drivers like the >> ct6900 >> don't use this interface. Here we have other means to get the base address. >> >> I'll move the conditional calling to the highest level and resubmit. > > I'd probably rahter see that you add a board_video_init() to the > ct6900 driver, and have this bail out. this could be done, but the problem here isn't ct6900 driver specific > Anatolij, what do you thik is the best solution here? i think, there could be other cases were the chip auto-probing in an init routine can't be accomplished, e.g. some pluggable (not PCI) graphic extension modules. If we move this bail out code to the highest level in the call chain ( here i mean to the top of drv_video_init() in drivers/video/cfb_console.c, we can cover other similar cases by providing board_video_skip() in the board code. Best regards, Anatolij -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
