On 07:26 Wed 13 May , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090512230224.gl...@game.jcrosoft.org> you wrote: > > > diff --git a/cpu/arm_cortexa8/omap3/mem.c b/cpu/arm_cortexa8/omap3/mem.c > > > index aa15f94..079c848 100644 > > > --- a/cpu/arm_cortexa8/omap3/mem.c > > > +++ b/cpu/arm_cortexa8/omap3/mem.c > > > @@ -41,6 +41,8 @@ unsigned int boot_flash_sec; > > > unsigned int boot_flash_type; > > > volatile unsigned int boot_flash_env_addr; > > > > > > +struct gpmc *gpmc_cfg; > > please do not expose it directly > > please use a function to get it > > Isn't this just adding to the memory footprint for little or no > benefit? avoid overwrite of the pointer by never use it directly
Best Regards, J. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
