On Thu, 2014-04-24 at 17:41 +0000, Alexey Brodkin wrote: > 1. Don't invalidate "sizeof(struct dmamacdescr)" but only > "roundup(sizeof(desc_p->txrx_status), ARCH_DMA_MINALIGN))".
OK. (Although given the realities of the real world values of ARCH_DMA_MINALIGN on every arch and the sizes of the structs & fields involved this isn't actually buying you anything at all) > 2. In the following lines implements rounding as well: Will fix as well. > 3. Check carefully if there're other instances of probably unaligned > cache operations. I'm not seeing any others, in practice or by eye-balling the code. > 4. Why don't you squeeze all 3 patches in 1 and name it like "fix > alignment issues with caches on some platforms"? Basically with all 3 > patches you fix one and only issue and application of any one of those 3 > patches doesn't solve your problem, right? These are the issues as I discovered them one by one. I can fold them if you like but doing them separately will aid bisection if one of them turns out to be wrong in some way. As you prefer. Ian. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
