On 04/17/2014 07:03 PM, York Sun wrote: > -----Original Message----- > From: Sun York-R58495 > Sent: Thursday, April 17, 2014 7:03 AM > To: Zhao Qiang-B45475; u-boot@lists.denx.de > Cc: Xie Xiaobo-R63061 > Subject: Re: [U-Boot] [PATCH v7 3/3] T1040QDS/U-QE: Add u-qe support to > t1040qds > > On 03/26/2014 01:04 PM, York Sun wrote: > > On 03/21/2014 01:21 AM, Zhao Qiang wrote: > >> > >> +static void qe_board_setup(void) > >> +{ > >> + u8 brdcfg15, brdcfg9; > >> + > >> + if (hwconfig("qe") && hwconfig("tdm")) { > > > > > > This is called before environmental variables are relocated to DDR. It > > will cause a warning. Please use hwconfig_f. > > > > Please fix this patch with a new version. No need to submit other patches > in this set.
This upstream patch, qe_board_setup() is called in misc_init_r , it is correct, Doesn't need to change. > > York > Regards, Zhao Qiang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot