On 4/12/2014 3:54 PM, Eric Nelson wrote: > Hi Fabio, > > On 04/11/2014 01:43 PM, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.este...@freescale.com> >> >> ECSPI chipselect (MX6_PAD_EIM_D19__GPIO3_IO19) is used with GPIO >> functionality, >> so it does not make sense to set its pad as SPI pin. >> >> Signed-off-by: Fabio Estevam <fabio.este...@freescale.com> >> --- >> Eric, >> >> This is untested. >> >> board/boundary/nitrogen6x/nitrogen6x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/boundary/nitrogen6x/nitrogen6x.c >> b/board/boundary/nitrogen6x/nitrogen6x.c >> index d9c05b0..f2492e4 100644 >> --- a/board/boundary/nitrogen6x/nitrogen6x.c >> +++ b/board/boundary/nitrogen6x/nitrogen6x.c >> @@ -331,7 +331,7 @@ int board_mmc_init(bd_t *bis) >> #ifdef CONFIG_MXC_SPI >> iomux_v3_cfg_t const ecspi1_pads[] = { >> /* SS1 */ >> - MX6_PAD_EIM_D19__GPIO3_IO19 | MUX_PAD_CTRL(SPI_PAD_CTRL), >> + MX6_PAD_EIM_D19__GPIO3_IO19 | MUX_PAD_CTRL(NO_PAD_CTRL), >> MX6_PAD_EIM_D17__ECSPI1_MISO | MUX_PAD_CTRL(SPI_PAD_CTRL), >> MX6_PAD_EIM_D18__ECSPI1_MOSI | MUX_PAD_CTRL(SPI_PAD_CTRL), >> MX6_PAD_EIM_D16__ECSPI1_SCLK | MUX_PAD_CTRL(SPI_PAD_CTRL), >> > > Tested-by: Eric Nelson <eric.nel...@boundarydevices.com> > Acked-by: Eric Nelson <eric.nel...@boundarydevices.com>
NAK. Please don't use NO_PAD_CTRL. What is wrong with SPI_PAD_CTRL. Your commit message doesn't say. It is an SPI pin (even if used as a GPIO,) so why doesn't it make sense. I think your fixing a problem that doesn't exist. Troy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot