Hi Masahiro-san,

On Mon, 2014-03-31 at 10:43 +0900, Masahiro Yamada wrote:
> I wanted to show retionale why a make target "tools-only" is better
> than "HOST_TOOLS_ONLY=yes".

Completely agree. I should have think a bit more before sending initial
patch because right after the email was sent I thought why didn't I use
a new target? :)

New target looks much better than some random variable.
It's shorter and easier to use.

> > 
> > Doesn't work for me:
> > ========
> > $ make tools-only
> >   HOSTCC  scripts/basic/fixdep
> >   HOSTCC  tools/aisimage.o
> >   HOSTCC  tools/crc32.o
> >   HOSTCC  tools/default_image.o
> >   HOSTCC  tools/dumpimage.o
> > In file included from include/version.h:11:0,
> >                  from tools/dumpimage.c:11:
> > include/timestamp.h:11:47: fatal error:
> > generated/timestamp_autogenerated.h: No such file or directory
> >  #include "generated/timestamp_autogenerated.h"
> >                                                ^
> > compilation terminated.
> > make[1]: *** [tools/dumpimage.o] Error 1
> > make: *** [tools-only] Error 2
> > ========
> 
> 
> 
> Oops - My bad.
> I was disabling timestamp.
> 
> 
> Could you fix like this?
> 
> tools-only: scripts_basic $(version_h) $(timestamp_h)
>       $(Q)$(MAKE) $(build)=tools
> 

Works as a charm for me as well.
Do you mind to submit your changes (because it was you who implemented
it properly and I don't want to "steal" your credits)?

Or I do it still on your behalf putting you in as an author?

-Alexey
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to