Hi Simon, Marek,
> Hi Marek,
>
> On 10 March 2014 13:04, Marek Vasut <ma...@denx.de> wrote:
> > Squash these warnings in pinmux.c found with GCC 4.8:
> >
> > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > warning: 'count' may be used uninitialized in this function
> > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++) { ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count' was
> > declared here int i, start, count;
> > ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start' may be
> > used uninitialized in this function [-Wmaybe-uninitialized] for (i
> > = start; i < start + count; i++) { ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > declared here int i, start, count;
> > ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > declared here struct s5p_gpio_bank *bank;
> > ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > warning: 'count' may be used uninitialized in this function
> > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++) { ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count' was
> > declared here int i, start, count;
> > ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start' may be
> > used uninitialized in this function [-Wmaybe-uninitialized] for (i
> > = start; i < start + count; i++) { ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > declared here int i, start, count;
> > ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may be
> > used uninitialized in this function [-Wmaybe-uninitialized]
> > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > declared here struct s5p_gpio_bank *bank;
> > ^
> >
> > Note that the warning is bogus, the function can never be called
> > with invalid 'peripheral' argument. GCC just cannot analyze this.
> >
> > Signed-off-by: Marek Vasut <ma...@denx.de>
> > Cc: Naveen Krishna Chatradhi <ch.nav...@samsung.com>
> > Cc: Akshay Saraswat <aksha...@samsung.com>
> > Cc: Rajeshwari S Shinde <rajeshwar...@samsung.com>
> > Cc: Simon Glass <s...@chromium.org>
> > Cc: Minkyu Kang <mk7.k...@samsung.com>
> > Cc: Tom Rini <tr...@ti.com>
>
> Acked-by: Simon Glass <s...@chromium.org>
>
> Thanks Marek, great to get that annoyance fixed.
Fix for this issue has been already posted :-) (one week ago)
http://patchwork.ozlabs.org/patch/327065/
But I don't mind if Marek's patch will be applied directly by Tom
before v2014.04 is released :-)
>
> Regards,
> Simon
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
