On Tue, Feb 04, 2014 at 04:02:56PM +0100, Stefano Babic wrote:
> Hi Hannes,
>
> On 04/02/2014 15:50, Hannes Petermaier wrote:
[snip]
> > Another thing is linewrapping of output strings, to obey to the rules i
> > have to format the string as following:
> >
> > if (i2c_probe(TPS65217_CHIP_PM)) {
> > printf("PMIC chip (0x%02x) not present! skipping" \
> > "further configuration.\n", TPS65217_CHIP_PM);
> > return;
> > }
> >
> > But this makes it impossible to grep the code in case of an error.
>
> You must combine a more complicate grep, maybe with the -A (after
> context) option or using a regexp. However, this is not a reason to
> break the rule.Strings are the reason to break the rule and we have checkpatch patched (mostly?) to not complain. It's even true in the kernel. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
