Hello Wolfgang,

Am 27.01.2014 07:50, schrieb Wolfgang Denk:
Dear Heiko,

In message<52e5fe93.2030...@denx.de>  you wrote:

+               cfg_noffset = fit_conf_get_node(working_fdt, NULL);
+               if (!cfg_noffset)
+                       return CMD_RET_FAILURE;

May need to print an error here, since otherwise it won't be clear
what went wrong.

Hmm... fit_conf_get_node() prints a dedicated error message if debug is
                                                               ^^^^^^^^^^^
activated... I thought this is enough ... ?
   ^^^^^^^^^

But in production versions (with debug NOT enabled) the user would
never know what went wrong?

Good argument, so, add an error message in next patch version.

bye,
Heiko
--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to